Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(biome_js_parser/state): use enumflags2 for SignatureFlag and ParsingContextFlag #3800

Merged
merged 1 commit into from
Sep 5, 2024
Merged

refactor(biome_js_parser/state): use enumflags2 for SignatureFlag and ParsingContextFlag #3800

merged 1 commit into from
Sep 5, 2024

Conversation

Javimtib92
Copy link
Contributor

Summary

Part of #3157

Adds enumflags2 to biome_js_parser SignatureFlag and ParsingContextFlag

Test Plan

I ran cargo t on the root and all tests passed. Current CI should pass

@github-actions github-actions bot added A-Parser Area: parser L-JavaScript Language: JavaScript and super languages labels Sep 5, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 5, 2024

CodSpeed Performance Report

Merging #3800 will degrade performances by 6.82%

Comparing Javimtib92:refactor/js-parser-state (2742c8a) with main (b1d55ff)

Summary

❌ 1 regressions
✅ 106 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main Javimtib92:refactor/js-parser-state Change
❌ pure_9395922602181450299.css[cached] 3.4 ms 3.6 ms -6.82%

@dyc3 dyc3 merged commit 689d205 into biomejs:main Sep 5, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyc3 dyc3 dyc3 approved these changes

Assignees
No one assigned
Labels
A-Parser Area: parser L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Javimtib92 @dyc3